search

mpv-player / mpv-build

🔨 Helper scripts to compile mpv on Linux
http://mpv.io
403 stars 104 forks source link

libplacebo-build script: fix ninja command #203

Closed ghost closed 9 months ago

ghost commented 1 year ago

without this it fails on alpine edge for whatever reason

Dudemanguy commented 1 year ago

Really late here, but does it work if you use meson install instead?

xymaxim commented 5 months ago

Just faced with the same issue on Alpine 3.19 with ninja installed via apk add ninja. 

ninja: open build.ninja: No such file or directory

In fact, with that apk command, /usr/bin/ninja is symlinked to /usr/bin/samu from the samurai package—ninja was replaced with samurai since Alpine 3.12—but for samu the position of pre-operand options is strict.

The solution would be to install the ninja-build package (non-conflicting with meson) and create a symlink: 

RUN apk add ... meson ninja-build ... \
  ln -sf /usr/lib/ninja-build/bin/ninja /usr/bin/ninja
sfan5 commented 5 months ago

Feel free to propose a new PR to fix this.