search

mpv-player / mpv-build

🔨 Helper scripts to compile mpv on Linux
http://mpv.io
403 stars 104 forks source link

Update README.rst with meson-style switches #213

Closed jmakovecki closed 1 year ago

jmakovecki commented 1 year ago

If using waf-style switches with a current meson build, it will fail with "error: unrecognized arguments". Update the README to mention the difference.

LaserEyess commented 1 year ago

You should also update this part, too https://github.com/mpv-player/mpv-build/blob/master/README.rst#building-libmpv

Also, it's meson, not "mason".

jmakovecki commented 1 year ago

You should also update this part, too https://github.com/mpv-player/mpv-build/blob/master/README.rst#building-libmpv

Missed that one, added.

Also, it's meson, not "mason".

Ah, typo in commit, my bad.

Dudemanguy commented 1 year ago

Good catch, but could you remove any mention of waf completely? The small existing section for it is good enough and in due time we'll eventually remove it.

jmakovecki commented 1 year ago

Thanks for the comments, mentions of WAF removed and libmpv switch updated.

Dudemanguy commented 1 year ago

Could you squash it to one commit and title it: README: update with meson-style switches?

jmakovecki commented 1 year ago

Could you squash it to one commit and title it: README: update with meson-style switches?

Sure, squashed.