mpv build failing since last week.

[Samueru-sama]

Hello, I have this appimage of mpv that I build using your build scripts.

Since last week the build has been failing with this error.

[61/233] Compiling C object libmpv.so.2.3.0.p/demux_demux_mf.c.o
[62/233] Compiling C object libmpv.so.2.3.0.p/demux_demux_edl.c.o
[63/233] Compiling C object libmpv.so.2.3.0.p/demux_demux_mkv.c.o
FAILED: libmpv.so.2.3.0.p/demux_demux_mkv.c.o 
cc -Ilibmpv.so.2.3.0.p -I. -I.. -Icommon -Ietc -Iplayer/javascript -Iplayer/lua -Isub -I/home/runner/work/mpv-AppImage/mpv-AppImage/mpv/mpv.AppDir/mpv-build/build_libs/include -I/usr/include/uuid -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/fribidi -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/lua5.2 -fvisibility=hidden -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_FILE_OFFSET_BITS=64 -Wdisabled-optimization -Wempty-body -Wformat -Wimplicit-fallthrough -Wparentheses -Wpointer-arith -Wshadow -Wundef -Wvla -Wno-cast-function-type -Wno-format-zero-length -Wno-missing-field-initializers -Wno-sign-compare -Wno-switch -Wno-unused-parameter -fno-math-errno -fno-signed-zeros -fno-trapping-math -Werror=format-security -D_GNU_SOURCE -Wmissing-prototypes -Wstrict-prototypes -Werror=implicit-function-declaration -Wno-pointer-sign -fPIC -D_REENTRANT -pthread -DPL_HAVE_PTHREAD -DPTHREAD_HAS_SETCLOCK -DPL_STATIC -MD -MQ libmpv.so.2.3.0.p/demux_demux_mkv.c.o -MF libmpv.so.2.3.0.p/demux_demux_mkv.c.o.d -o libmpv.so.2.3.0.p/demux_demux_mkv.c.o -c ../demux/demux_mkv.c
In file included from /home/runner/work/mpv-AppImage/mpv-AppImage/mpv/mpv.AppDir/mpv-build/build_libs/include/libplacebo/utils/libav_internal.h:45,
                 from /home/runner/work/mpv-AppImage/mpv-AppImage/mpv/mpv.AppDir/mpv-build/build_libs/include/libplacebo/utils/libav.h:293,
                 from ../demux/demux_mkv.c:40:
/home/runner/work/mpv-AppImage/mpv-AppImage/mpv/mpv.AppDir/mpv-build/build_libs/include/libavutil/hwcontext_vulkan.h:44:5: error: unknown type name 'VkVideoCodecOperationFlagBitsKHR'
   44 |     VkVideoCodecOperationFlagBitsKHR video_caps;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[64/233] Compiling C object libmpv.so.2.3.0.p/demux_demux_lavf.c.o
[65/233] Compiling C object libmpv.so.2.3.0.p/demux_demux_mkv_timeline.c.o
[66/233] Compiling C object libmpv.so.2.3.0.p/demux_demux.c.o
ninja: build stopped: subcommand failed.
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -C /home/runner/work/mpv-AppImage/mpv-AppImage/mpv/mpv.AppDir/mpv-build/mpv/build -j 4
Error: Process completed with exit code 1.

Is there anything that I need to update?

[jeeb]

That is a Vulkan extension definition, so Vulkan is the thing the version of which you should check.

As I look at the inclusion listing, it seems like libplacebo's FFmpeg helper header includes the FFmpeg vulkan hwcontext header, which in turn now requires newer Vulkan headers as it refers to that enum type?

[Samueru-sama]

That is a Vulkan extension definition, so Vulkan is the thing the version of which you should check.

As I look at the inclusion listing, it seems like libplacebo's FFmpeg helper header includes the FFmpeg vulkan hwcontext header, which in turn now requires newer Vulkan headers as it refers to that enum type?

Thanks for the quick response, does that mean the issue is related to this other issue?

[stax76]

Thanks for the quick response, does that mean the issue is related to this https://github.com/mpv-player/mpv-build/issues/234

I think it is the same cause, the guide provided by rodrigomorales1 solved it for me.

[Samueru-sama]

Thanks for the quick response, does that mean the issue is related to this #234

I think it is the same cause, the guide provided by rodrigomorales1 solved it for me.

Indeed, I just tested building the vulkan headers and now the build goes thru. Thank you!