search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
26.83k stars 2.85k forks source link

Latest versions of MPV doesn't work with Discord Live Screen Share. #10432

Open Nao128 opened 1 year ago

Nao128 commented 1 year ago

I wanted to report this issue for a while, so I'm here to let this be known. Windows OS build: 19044.1826

I've been hosting my videos on MPV with SVP for years on Discord Live Screen share with friends.

But a few months ago, MPV stopped working, so I was forced to jump to VLC. Only today where I actually bothered to look for solutions and found a way for it to work again by rolling back to an older working version.

Issues being:

Discord Live would freeze when both Discord window and MPV player are fullscreened. (Yes, if you turn discord to windowed mode, the screen starts to move again. This goes same with the player if it's windowed, it plays properly on the screen share) Tabbing out of the player in anyway will freeze Discord screen share as well.

I've then contacted Discord support, and they've let me try PBT and Alpha version of discord to test it. Both still didn't work. Except for PBT which had a Windows.Graphics.Capture feature which was able to capture mpv while fullscreened or tabbed out. The downside only being the annoying Yellow border from windows capture. So I didn't want that.

I then went to https://sourceforge.net/projects/mpv-player-windows/files/64bit/ to test out every single version of MPV to track down where it started freezing. And Bingo!

The last version that was working is mpv-x86_64-20220410-git-2cafe51 Versions mpv-x86_64-20220417-git-305332f up till the Latest are where the Discord Live screen share stopped working on fullscreened or tabbed out state.

Is there a particular change that caused this to happen?

But either way, I'm leaving this here to be known as an issue, and I hope newer versions could fix this problem. I love hosting videos at high frame rate on discord. even if it's limited to 60fps. MPV alone is the best player for me when reaching 144 frames with SVP while VLC is only limited to 77, and has de-syncing issues most of the time.

mpv mpv2

Buldev commented 1 year ago

In personal experience, this seems to be triggered by anything partially or fully covering the mpv window. Haven't been able to fix this in any other way than downgrading unfortunately.

jhartikainen commented 1 year ago

Seeing this as well on latest mpv. It's enough to simply set another window to focus for it to do this. Downgrading to version mentioned by Nao128 fixes the issue.

fireattack commented 1 year ago

Just noticed this bug after updated MPV from a very old version.

Here is the changes between these two commit for the interested: https://github.com/mpv-player/mpv/compare/2cafe51...305332f

I cannot pin down which one causes it, maybe vo-related ones?

fireattack commented 1 year ago

Wow, changing vo to gpu-next fixed it.

Dudemanguy commented 11 months ago

So x11 and wayland do have an optimization to not render anything if the window is hidden. That linked range of commits includes those changes. There is an option now, --force-render, which will always render regardless of the window being hidden or not. Of course, OP was using windows so this should have absolutely nothing to do with whatever he experienced (windows doesn't have this optimization) but I thought I'd mention this since that particular range of commits was mentioned.