vo_gpu-next: vapoursynth filter seems could not receive dolbyvision's metadata

hooke007 commented 1 year ago

Important Information

Provide following Information:

mpv version https://github.com/shinchiro/mpv-winbuild-cmake/releases/tag/20220723
Windows Version win11 release
Source of the mpv binary https://github.com/shinchiro/mpv-winbuild-cmake/releases/tag/20220723
If known which version of mpv introduced the problem N/A
Possible screenshot or video of visual glitches

Reproduction steps

# mpv.conf
vo=gpu-next

run mpv.exe and play a dv file, and then activate any vapoursynth filter.
vf toggle vapoursynth="~~/test0.vpy"
```
# test0.vpy
video_in.set_output()
```

Expected behavior

correct color

Actual behavior

mpv-shot0001

Log file

mpv-test.log

quietvoid commented 1 year ago

The side data doesn't propagate through the vapoursynth vf. Not sure if it would be easily doable, but from my perspective it isn't.

chainikdn commented 1 year ago

Not 100% sure about the patch cause there's strange color blinking sometimes (not always, just in some scenes) when the filter increases frame rate. Maybe I'm missing something important here o_O

hooke007 commented 1 year ago

https://github.com/mpv-player/mpv/issues/10390#issuecomment-1179725841

when the filter increases frame rate

Probably there is the loss of luminace info in the extra frames created by vs.

chainikdn commented 1 year ago

it doesn't happen on every inserted frame more like some frames occasionally lose this DoVi data

Durden-T commented 9 months ago

same for me

mpv-player / mpv