vo_gpu-next: `--tone-mapping` did nothing with dovi p8 (dvhe.08.06)

mpv-player / mpv

🎥 Command line video player

https://mpv.io

Other

27.69k stars 2.86k forks source link

vo_gpu-next: `--tone-mapping` did nothing with dovi p8 (dvhe.08.06) #11344

Closed hooke007 closed 1 year ago

hooke007 commented 1 year ago

Important Information

mpv version https://github.com/mpv-player/mpv/commit/d1cf89b65554d6501fe62cc0989fab97180b8377
Platform and Version win10 pro 22H2
Source of the mpv binary https://github.com/zhongfly/mpv-winbuild/releases/tag/2023-02-20

Reproduction steps

Load a dvhe.08.06 video and then cycle-values tone-mapping bt.2390 bt.2446a st2094-40. Snipaste_2023-02-21_13-48-43

Expected behavior

--tone-mapping should work correctly.

Actual behavior

Most values of --tone-mapping show the same output (except clip).

Log file

Maybe https://github.com/mpv-player/mpv/issues/11338 is related.

Sample files

N/A

quietvoid commented 1 year ago

Now that the scene/frame brightness is available, if the ~detected~ metadata peak brightness is below target-peak, tone mapping is set to clip. This is a new behaviour that wasn't present before.

So if you were to compare with clip in low brightness shots, the only difference should be black point compensation. Is this the case with your sample?

If not please provide at least a frame of the original video.

hooke007 commented 1 year ago

If i understood properly, it is not a bug, right?

(tone-mapping-visualize)

haasn commented 1 year ago

Looks intended to me. You are seeing black point compensation due to the output display not handling absolute black levels (red region), but otherwise nothing needs to be done (blue region = good).

hooke007 commented 1 year ago

Thanks for the explanation. BTW, another real bug (about tone-mapping-visualize) was found. I would open another issue.