search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
27.89k stars 2.87k forks source link

Make stats.lua 's page 1 scrollable #11544

Open hooke007 opened 1 year ago

hooke007 commented 1 year ago

I think it was forgotten in the commit https://github.com/mpv-player/mpv/commit/c7b94c03f1c85f2da07ed9268119a54653b9b31c

Because the script-opt would print those contents in page 1. https://github.com/mpv-player/mpv/blob/68b3239b523cd75ba0a12f680ac7bc77e5647d40/player/lua/stats.lua#L30

Expected behavior of the wanted feature

To make stat's page 1 scrollable.

Alternative behavior of the wanted feature

N/a

Log file

N/a

guidocella commented 3 months ago

22a8b99f7a says print_perfdata_passes was only needed until stats pages were implemented, so maybe it should just be removed?

hooke007 commented 3 months ago

With more and more info are attached on the first page, I'll afraid that we will still need scrolling on some day.

And even now I think you cannot force all users always set suitable font (size) to make all info stay in the visible area.

kasper93 commented 3 months ago

With more and more info are attached on the first page, I'll afraid that we will still need scrolling on some day.

Page 1 is currently blocked for any new changes until some of it's elements are split to another page.