mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
28.19k stars 2.89k forks source link

Subtitles are moved off screen when using pan&scan feature #11714

Open WildPenquin opened 1 year ago

WildPenquin commented 1 year ago

Mpv will move subtitles off screen (partially) if pan&scan feature is used (obviously, with not burned-in subtitles such as DVD subtitles).

This is annoying for example with DVDs, played on an ultrawide monitor.

Important Information

Reproduction steps

Play a video with not-burned-in subtitles (such as DVD subtitles), encoded with black bars (letterboxed). Use Pan&scan.

Expected behavior

Subtitles should always stay on screen. Pan&Scan should not affect their position on screen, but their position should be handled separately.

Actual behavior

Subtitles are always shown in relation to the original video dimensions. They will move off screen (partially), if video is zoomed.

Log file

When playing a DVD backup, selecting English audio, Finnish subtitles, and then fast forwarding to a part with subtitles to, I get:

Log: https://0x0.st/HqOA.txt Screenshot: https://0x0.st/HqOm.png

Possibly related:

Issue #11705

This issue could affect all platforms.

Workaround:

Press 'r'. Or 'SHIFT+r' if subtitles are too high up.

I didn't find that out before I had typed out this bug report!

Other notes:

Most content in wider than 16:9 aspect ratios, such as 2.35:1, are (sadly) encoded letterboxed. When played back on ultrawide displays they will display black areas all around. It is much desired to zoom into the picture so that there are no black bars all around.

However, the last points are irrelevant - the subtitles should not "move" in relation to screen borders when zooming in, even if zooming on a display matching the expectations of the letterboxing.

IIRC this issue has been reported and was fixed a long, long time ago, it may have even been in mplayer before mpv was a thing. If so, this could be a regression.

llyyr commented 1 year ago

Most content in wider than 16:9 aspect ratios, such as 2.35:1, are (sadly) encoded letterboxed. When played back on ultrawide displays they will display black areas all around. It is much desired to zoom into the picture so that there are no black bars all around.

Use dynamic-crop.lua for this purpose. But --sub-ass-force-margins=yes should work in this case as well

However, the last points are irrelevant - the subtitles should not "move" in relation to screen borders when zooming in, even if zooming on a display matching the expectations of the letterboxing.

mpv internally converts .srt subs to .ass and uses libass to render them, this is completely sane behavior for .ass files.