search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
27.82k stars 2.87k forks source link

[input] No bind found for key '0x8 ' in xterm #1185

Closed cfillion closed 9 years ago

cfillion commented 9 years ago

Hi,

Since the 0.6.0 release, mpv prints this when hitting the Backspace key in xterm:

[input] No bind found for key '0x8     '.

The key is correctly recognized from the video output window or another terminal emulator like urxvt. Also, downgrading to 0.5.4 resolves this issue.

I'm using the latest version of mpv (now 0.6.1) and xterm (312) from Arch Linux's repositories.

ghost commented 9 years ago

Backspace in xterm works for me.

The cause for this is that ncurses/termcap was disabled by default, and now we do the mapping manually. So some terminals are going to break. xterm should be fully supported though.

cfillion commented 9 years ago

I tried an older version of xterm (specifically v297 from a Fedora 20 VM) and the Backspace key worked fine in mpv.

However, building a newer xterm from source (http://invisible-island.net/xterm/, the same as Arch Linux) made this bug happen again.

Are the trailing spaces after the key code in mpv's output related to this issue? Or maybe this is in fact a xterm bug? Though I don't have this problem with other TUI softwares or mpv before the changes you mentioned.

ghost commented 9 years ago

Thanks for clarifying this. The xterm source you linked still used another code for some reason, but I fixed it anyway since it seems to be a code even produced by the original vt100 (probably).

The trailing space is just a formatting glitch, I removed that too.