Frame Timings: Redraw: Not Updating Frequently If Video Is 60fps

Obegg commented 1 year ago

Important Information

Provide following Information:

mpv version:

mpv v0.36.0-315-g7a76cf4d Copyright © 2000-2023 mpv/MPlayer/mplayer2 projects
built on Sep 19 2023 16:34:36
libplacebo version: v6.292.0-400-g63f5089-dirty
FFmpeg version: N-112128-gfa20f5cd9
FFmpeg library versions:
libavutil       58.25.100
libavcodec      60.26.100
libavformat     60.13.100
libswscale      7.3.100
libavfilter     9.11.100
libswresample   4.11.100

Windows Version:

Edition Windows 10 Pro
Version 22H2
Installed on    ‎28/‎04/‎2023
OS build    19045.3448
Experience  Windows Feature Experience Pack 1000.19044.1000.0

Source of the mpv binary: https://github.com/shinchiro/mpv-winbuild-cmake/releases (mpv-x86_64-v3-20230919-git-7a76cf4.7z)
If known which version of mpv introduced the problem: No
Possible screenshot or video of visual glitches:

Reproduction steps

mpv --no-config --vo=gpu-next -v -v --log-file=output.txt bbb-1920x1080-cfg02.mkv

Expected behavior

When using stats.lua page 2 to view Frame Timing the Redraw section should update every second (the same way the Fresh section updates every second).

Actual behavior

When using stats.lua page 2 to view Frame Timing the Redraw section doesn't update every second. (It does update maybe between 5 seconds to 15 seconds, each update is random interval).

Log file

output.txt

Sample files

https://www.libde265.org/hevc-bitstreams/bbb-1920x1080-cfg02.mkv

Dudemanguy commented 1 year ago

Can't reproduce. I'm not sure what the stats.lua timer is but it updates roughly every second for me. Also looks like this build is one commit before 27a78276eb4b68f230e441e1baedf26f3cd66fbd so that shouldn't be related.

Obegg commented 1 year ago

When you say "Can't reproduce" - did you test it on a Windows 10 machine using NVIDIA GPU playing the same video file?

I have this issue when I play any video that's 60fps, it doesn't matter if the video is a local file or a YouTube video. I believe this issue is not new, because I vaguely remember ignoring it.

Dudemanguy commented 1 year ago

Sorry I guess I should have been clearer. I'm on Linux (amdgpu), and I can't reproduce it with that file or any other 60fps video I have lying around.

llyyr commented 1 year ago

I can't reproduce this on wayland either. Did this used to not be like this at some point? A bisect would be helpful

Obegg commented 1 year ago

Did this used to not be like this at some point? A bisect would be helpful

It was always like this. The only improved I've seen with my testing is that at the starting point (the oldest build) it wasn't updating at all, but at some point around 2023-03 it improved by updating but not frequently.

llyyr commented 1 year ago

Are you pressing i or toggling it with I?

Obegg commented 1 year ago

Shift+i then 2 to view Frame Timings.

Obegg commented 1 year ago

Noticed the same issue on video file 480i 29.970fps (mpv --no-config --vo=gpu-next) So it's not just 60fps video files.

I don't have this issue when playing 1080p 23.976fps video files (did not use --no-config).

Obegg commented 2 months ago

I just tested it on 60fps video to make sure if this issue still exists after all this time and I found out that this issue still exists. The Redraw simply doesn't update.

Obegg commented 2 months ago

mpv-player / mpv