search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
28.32k stars 2.9k forks source link

Inverse tone mapping for spline insensitive to tone mapping param #12727

Open AstralStorm opened 1 year ago

AstralStorm commented 1 year ago

Important Information

Windows Shinchiro build. mpv v0.36.0-627-g05e6813e Copyright © 2000-2023 mpv/MPlayer/mplayer2 projects built on Oct 23 2023 00:24:03 libplacebo version: v6.338.0-43-ga59333c-dirty FFmpeg version: N-112502-g6e4030a07 FFmpeg library versions: libavutil 58.27.100 libavcodec 60.30.102 libavformat 60.15.100 libswscale 7.4.100 libavfilter 9.11.100 libswresample 4.11.100

Reproduction steps

Add inverse-tone-mapping and try to use tone-mapping-param that is not. Observe it does nothing, including with tone-mapping-visualize.

Expected behavior

Inverse tone mapping midpoint should move according to the tone mapping param.

Actual behavior

The midpoint does not change.

AstralStorm commented 1 year ago

Correction: the midpoint does minimally budge, but I think it's scaled in SDR or something, and target-contrast highly affects the operation of the curve. Values of 100 maybe push it up higher a bit, and 0.01 minimally lower.