Please considering remove `smb` from `X-KDE-Protocols` in desktop entry.

merrkry commented 4 months ago

Some distros don't include --enable-libsmbclient in ffmpeg build. File managers like Dolphin will try use smb:// as target as mpv's current desktop entry includes smb in X-KDE-Protocols, and mpv crashes because local ffmpeg lacks smb support. As --enable-libsmbclient isn't listed as dependency here, I suggest smb should be removed from X-KDE-Protocols, to make the entry file universal on various distros.

References (may be more distros to be added here):

Important Information

mpv version: 0.38.0
Linux Distribution and Version: Archlinux
Source of the mpv binary: official Archlinux repo
~~If known which version of mpv introduced the problem~~
Window Manager and version: kwin 6.0.4
~~GPU model, driver and version~~
~~Possible screenshot or video of visual glitches~~

Reproduction steps

Connect a samba server with Dolphin
click to open a video with mpv
mpv crashes

Expected behavior

Target file should be provided with kio-fuse (under /run/user/1000/kio-fuse-*/) instead of using smb:// directly.

Actual behavior

Dolphin directly passes smb:// link to mpv, and mpv crashes because local ffmpeg build doesn't support it.

Log file

$ mpv smb://<blabla>
[ffmpeg] Protocol not found. Make sure FFmpeg is compiled with networking support.
Failed to open smb://<blabla>.
Exiting... (Errors when loading file)

Sample files

sfan5 commented 4 months ago

duplicate of #8731

CounterPillow commented 4 months ago

and mpv crashes because local ffmpeg build doesn't support it.

As a note of correction, this is not a crash. mpv exits on its own volition.

mpv-player / mpv