search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
26.89k stars 2.84k forks source link

stats.lua: indent video and audio profile #14148

Open 6ws opened 2 months ago

6ws commented 2 months ago

Eliminates clutter by moving the profile into its own subsection.

kasper93 commented 2 months ago

Just like #13913 and #13866 it is blocked, because we don't have much vertical lines left. There was idea in #13913 to move all track related properties to new page and make page 1 only for stats. But exact split is also not clear to make it readable.

6ws commented 2 months ago

In this case, the profile shares the same line as the codec. I probably should have said indentation instead of subsection. Sorry about that!

github-actions[bot] commented 2 months ago

Download the artifacts for this pull request:

Windows * [mpv-i686-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1503333906.zip) * [mpv-x86_64-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1503334246.zip) * [mpv-x86_64-windows-msvc](https://nightly.link/mpv-player/mpv/actions/artifacts/1503346205.zip)
macOS * [mpv-macos-14-arm](https://nightly.link/mpv-player/mpv/actions/artifacts/1503329869.zip) * [mpv-macos-13-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1503333644.zip) * [mpv-macos-12-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1503344205.zip)
kasper93 commented 2 months ago

Ah, I see what you did. In this case we can consider it. I didn't do that to not make this line too long. Maybe it is more readable though.

kasper93 commented 3 weeks ago

@6ws Sorry, forgot about you. What do you think we keep profile as is, but move decoder out? bla [<profile>] SW: decoder this would be symmetric with bla [<profile>] HW: decoder too.

6ws commented 3 weeks ago

The current logic has [decoder] appear only if it is not native to FFmpeg, e.g., libdav1d. Would it be better to have SW appear regardless of the decoder? It would have the side effect of lengthening the entire line, but otherwise, I am in favor of your suggestion.