search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
28.66k stars 2.93k forks source link

Support images as chapter marks #14235

Open kleinf opened 6 months ago

kleinf commented 6 months ago

Expected behavior of the wanted feature

There are some podcasts who use images as chapter marks and mostly only mobile apps (for example AntennaPod) support the display of this images.

Recently someone works on a player to bring this feature to us windows users: https://mp3chapters.github.io/player/

The developer made his code open source so maybe you can use this as inspiration on how to extract the ids from the mp3 files: https://github.com/mp3chapters/mp3chapters.github.io

Your player mpv has already the feature to show chapters as text and the feature to show covers as image in the gui so this would be just a step further to also show the images of the chapter marks like in this screenshot: https://mp3chapters.github.io/player/screenshot.jpg

Just to be clear: I don't expect seeing the images in the chapter list. It would be enough for me to see the images like the cover image one at a time once the chapters are reached.

Additional information about chapter marks with sample files: https://auphonic.com/blog/2013/07/03/chapter-marks-and-enhanced-podcasts/

Alternative behavior of the wanted feature

No response

Log File

No response

Sample Files

The following example files are used to demonstrate chapters:

Auphonic Chapter Marks Demo, MP4 Auphonic Chapter Marks Demo, MP3 Auphonic Chapter Marks Demo, Opus Auphonic Chapter Marks Demo, Ogg Vorbis

sfan5 commented 5 months ago

While it may seem like not much of a difference, displaying some kind of images pulled from file metadata alongside chapters in the osc is entirely different and will require new APIs and a medium amount of effort. Showing chapter images instead of the thumbnail when playing the relevant chapter is not any easier.

It's likely that this won't be implemented.

kasper93 commented 5 months ago

I think it is already implemented by various osc forks and scripts. It just that it was never upstreamed.

kleinf commented 5 months ago

Hi @sfan5 and hi @kasper93, thanks a lot for your replies. I fully understand if you don't want to integrate the feature into the main code of the mpv-player if it messes up the code to much.

But if you decide against the upstream may I kindly ask for some links to the forked projects who have implemented this feature?