mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
28.04k stars 2.88k forks source link

ao_pipewire: revert EOF handling #14239

Closed ruihe774 closed 4 months ago

ruihe774 commented 4 months ago

My preliminary attempt to fix #14237.

@monarc99 @christoph-heinrich please check it.

github-actions[bot] commented 4 months ago

Download the artifacts for this pull request:

Windows * [mpv-i686-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1542906126.zip) * [mpv-x86_64-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1542906600.zip) * [mpv-x86_64-windows-msvc](https://nightly.link/mpv-player/mpv/actions/artifacts/1542919957.zip)
macOS * [mpv-macos-12-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1542905365.zip) * [mpv-macos-13-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1542905756.zip) * [mpv-macos-14-arm](https://nightly.link/mpv-player/mpv/actions/artifacts/1542903747.zip)
christoph-heinrich commented 4 months ago

Still happens

monarc99 commented 4 months ago

I can confirm that it still occurs.

Both when I run a single Twitch live stream via streamlink+mpv and when I run several at the same time. Then it occurs even faster.

ruihe774 commented 4 months ago

It's still unclear but I think I'd better revert it for now.

Dudemanguy commented 4 months ago

FWIW, I couldn't seem to trigger this with my attempts but let's just revert this for now.