search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
26.69k stars 2.83k forks source link

sub/sd_ass: rewrite is_animated() #14296

Closed kasper93 closed 3 weeks ago

kasper93 commented 4 weeks ago

Using strchr should be faster as it is optimized for the job. Also ensure that tags are not escaped and are within {} correctly. This also is important for performance as it allows to scan only needed areas of the string.

kasper93 commented 4 weeks ago

@rcombs @avih @Dudemanguy

github-actions[bot] commented 4 weeks ago

Download the artifacts for this pull request:

Windows * [mpv-i686-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1570440054.zip) * [mpv-x86_64-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1570444009.zip) * [mpv-x86_64-windows-msvc](https://nightly.link/mpv-player/mpv/actions/artifacts/1570458915.zip)
macOS * [mpv-macos-12-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1570439119.zip) * [mpv-macos-13-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1570440878.zip) * [mpv-macos-14-arm](https://nightly.link/mpv-player/mpv/actions/artifacts/1570438089.zip)
avih commented 4 weeks ago

It looks like it should work.

kasper93 commented 3 weeks ago

Enough bikesheding.