mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
26.69k stars 2.83k forks source link

input: only begin VO dragging if the section allows #14301

Closed na-na-hi closed 4 weeks ago

na-na-hi commented 4 weeks ago

Otherwise, on sections which don't allow VO dragging, the mouse button is force released and dragging events won't be generated.

Fixes: 349aac462e0ce4380df79e59383293c4db6a6039

github-actions[bot] commented 4 weeks ago

Download the artifacts for this pull request:

Windows * [mpv-i686-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1569376212.zip) * [mpv-x86_64-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1569379199.zip) * [mpv-x86_64-windows-msvc](https://nightly.link/mpv-player/mpv/actions/artifacts/1569387478.zip)
macOS * [mpv-macos-12-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1569376301.zip) * [mpv-macos-13-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1569376974.zip) * [mpv-macos-14-arm](https://nightly.link/mpv-player/mpv/actions/artifacts/1569375663.zip)
rorgoroth commented 4 weeks ago

This seems to fixes the issue I was having after recent changes:

Cannot drag progress bar to seek unless setting input-builtin-dragging=no but then cannot drag the window around the screen.

Thanks 👍