search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
26.65k stars 2.83k forks source link

player/command: alias playback-time to time-pos #14381

Closed Dudemanguy closed 1 week ago

Dudemanguy commented 1 week ago

Since 5988473b7624d82cb6c523463eaf66b2a5aa0c5d, time-pos and playback-time are exactly the same so there's a redundancy in the properties. The slight difference that time-pos previously had was both unexpected and not useful at all for script/api users (e.g. virtually nobody handles the seeking edge case time-pos used to have), so I opted to deprecate a property instead. Searching on github suggests that people tend to use, time-pos more. A good chunk of playback-time usage is simply forks from our own OSC which happens to use that, so I figured time-pos is the better property to keep of the two.

playback-time is a pretty old property though so the deprecated alias will likely stay for quite a while.

github-actions[bot] commented 1 week ago

Download the artifacts for this pull request:

Windows * [mpv-i686-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1617285242.zip) * [mpv-x86_64-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1617288526.zip) * [mpv-x86_64-windows-msvc](https://nightly.link/mpv-player/mpv/actions/artifacts/1617325906.zip)
macOS * [mpv-macos-12-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1617284742.zip) * [mpv-macos-13-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1617279860.zip) * [mpv-macos-14-arm](https://nightly.link/mpv-player/mpv/actions/artifacts/1617280896.zip)
Dudemanguy commented 1 week ago

I changed my mind and decided to make it just an alias instead.