search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
28.1k stars 2.88k forks source link

vo_gpu: undeprecate --gamma-factor and --gamma-auto #14540

Open Akemi opened 2 months ago

Akemi commented 2 months ago

alternative to #14369

github-actions[bot] commented 2 months ago

Download the artifacts for this pull request:

Windows * [mpv-i686-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1697977298.zip) * [mpv-x86_64-w64-mingw32](https://nightly.link/mpv-player/mpv/actions/artifacts/1697978662.zip) * [mpv-x86_64-windows-msvc](https://nightly.link/mpv-player/mpv/actions/artifacts/1697985601.zip)
macOS * [mpv-macos-12-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1697976091.zip) * [mpv-macos-13-intel](https://nightly.link/mpv-player/mpv/actions/artifacts/1697976933.zip) * [mpv-macos-14-arm](https://nightly.link/mpv-player/mpv/actions/artifacts/1697976654.zip)
guidocella commented 2 months ago

It was unclear to me too why these were deprecated. These will have to be added to gpu-next if undeprecated.

Dudemanguy commented 2 months ago

--gamma-factor is trivial. not sure about --gamma-auto

kasper93 commented 2 months ago

These will have to be added to gpu-next if undeprecated.

/cc @haasn

Akemi commented 2 months ago

maybe it would be better to make 'ambient lux' an observable property which can be changed by the backend, and whoever wants to do something with that value can do it with a script? the old assumption was this after all and is hardcoded:

1.0
    Pitch black or dimly lit room (default)
1.1
    Moderately lit room, home
1.2
    Brightly illuminated room, office

NOTE: This is based around the assumptions of typical movie content, which
contains an implicit end-to-end of about 0.8 from scene to display. For
bright environments it can be useful to cancel that out.

with an observable property the behaviour could be changed by the user to whatever they like.