search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
27.83k stars 2.87k forks source link

Support icc-profile color management in Wayland. #8151

Open laichiaheng opened 3 years ago

laichiaheng commented 3 years ago

Before requesting a new feature make sure it hasn't been requested yet. https://github.com/mpv-player/mpv/labels/meta%3Afeature-request

Expected behavior of the wanted feature

icc-profile-auto works like it does in Xorg.

Alternative behavior of the wanted feature

icc-profile-auto doesn't work.

Log file

https://0x0.st/i0Y0.txt

Dudemanguy commented 3 years ago

There would need to be upstream wayland-protocol support for this. Particularly this one.

aufkrawall commented 3 years ago

Having the ability to feed mpv 3D LUTs created by DisplayCal as a platform-agnostic solution is out of scope? It would also help with #8009 .

Dudemanguy commented 3 years ago

3D LUTs isn't a well-defined standard. On the other hand, ICC profiles are and can do everything (plus more) that a 3D LUT can do. The linked wayland protocol above handles ICC profiles (of course) and mpv already can internally so that's the direction to go.

aufkrawall commented 3 years ago

Sure, yet my layman impression is that it probably would be rather easy to implement and it wouldn't hurt anyone to have it either. :)

I'd also be very happy if it was just outside of mpv as a user shader.

haasn commented 3 years ago

You can already implement custom 3DLUTs as user shaders, since the ability to upload your own 3D textures is already present. Of course, it becomes entirely your responsibility to make sure the result is correct and intended.