Closed NightMachinery closed 3 years ago
CogentRedTester
commented
4 years ago I don't quite understand what you're trying to accomplish, but you probably want to be editting the stream-open-filename property during an on_load hook. Use mp.add_hook
NightMachinery
commented
4 years ago @CogentRedTester commented on Oct 8, 2020, 5:52 PM GMT+3:30:
I don't quite understand what you're trying to accomplish, but you probably want to be editting the stream-open-filename property during an on_load hook. Use mp.add_hook
I am trying to add ..green.. to the filename of files currently playing in mpv, and ..teal.. to the files when mpv is done with them. The problem is that when I go back and forth between files in a loaded playlist (I use autoload to load the whole directory), mpv's playlist paths don't get updated with the new filenames and so mpv throws nonexistent file errors.
I tried your suggestion, but it did not solve this problem, and it also has the drawback of being run for all "loaded" files (the autoload plugin loads the whole dir), not the currently starting file.
Here is the log:
❯ mpv BBC\ Earth.mkv
2020-10-08 19:47:55.370 mpv[15980:84655881] This NSLayoutConstraint is being configured with a constant that exceeds internal limits. A smaller value will be substituted, but this problem should be fixed. Break on BOOL _NSLayoutConstraintNumberExceedsLimit(void) to debug. This will be logged only once. This may break in the future.
[autoload] Prepending BBC Earth2.mkv
[autotag] Greened: /Users/evar/Base/cache/test/BBC Earth..green..mkv
(+) Video --vid=1 (*) (hevc 1920x1080 25.000fps)
(+) Audio --aid=1 --alang=eng (*) (aac 2ch 48000Hz)
File tags:
Title: Frozen Planet Disc 1
[autotag] Updated path: /Users/evar/Base/cache/test/BBC Earth.mkv
AO: [coreaudio] 48000Hz stereo 2ch doublep
VO: [libmpv] 1920x1080 yuv420p10
AV: 00:00:00 / 00:00:17 (1%) A-V: 0.001 DS: 1.300/0 Dropped: 6
Audio/Video desynchronisation detected! Possible reasons include too slow
hardware, temporary CPU spikes, broken drivers, and broken files. Audio
position will not match to the video (see A-V status field).
AV: 00:00:02 / 00:00:17 (12%) A-V: 0.012 DS: 1.055/3 Dropped: 31
[autotag] end-file's reason: stop
Playing: /Users/evar/Base/cache/test/BBC Earth2.mkv
[autoload] Adding BBC Earth..green..mkv
[autotag] ntag-mv '/Users/evar/Base/cache/test/BBC Earth..green..mkv' '/Users/evar/Base/cache/test/BBC Earth.mkv'
[autotag] ntag-mv '/Users/evar/Base/cache/test/BBC Earth.mkv' '/Users/evar/Base/cache/test/BBC Earth..teal..mkv'
[autotag] Greened: /Users/evar/Base/cache/test/BBC Earth2..green..mkv
(+) Video --vid=1 (*) (hevc 1920x1080 25.000fps)
(+) Audio --aid=1 --alang=eng (*) (aac 2ch 48000Hz)
File tags:
Title: Frozen Planet Disc 1
[autotag] Updated path: /Users/evar/Base/cache/test/BBC Earth2.mkv
AV: 00:00:01 / 00:00:17 (7%) A-V: -0.007 DS: 2.500/0
Playing: /Users/evar/Base/cache/test/BBC Earth..green..mkv
[autotag] end-file's reason: stop
[autotag] ntag-mv '/Users/evar/Base/cache/test/BBC Earth2..green..mkv' '/Users/evar/Base/cache/test/BBC Earth2.mkv'
[autotag] ntag-mv '/Users/evar/Base/cache/test/BBC Earth2.mkv' '/Users/evar/Base/cache/test/BBC Earth2..teal..mkv'
[autotag] Greened:
[file] Cannot open file '': No such file or directory
Failed to open .
[file] Cannot open file '': No such file or directory
Failed to open .
Playing: /Users/evar/Base/cache/test/BBC Earth.mkv
[autotag] end-file's reason: error
[autotag] h_reify_ntag-rmadd: Nonexistent file:
[autotag] Greened:
[file] Cannot open file '': No such file or directory
Failed to open .
[file] Cannot open file '': No such file or directory
Failed to open .
Exiting... (Some errors happened)
[autotag] end-file's reason: error
[autotag] h_reify_ntag-rmadd: Nonexistent file:Here is the updated script:
local utils = require 'mp.utils'
local options = require 'mp.options'
function log(string, secs)
secs = secs or 2.5 -- secs defaults to 2.5 when the secs parameter is absent
mp.msg.info(string) -- This logs to the terminal
-- mp.osd_message(string, secs) -- This logs to mpv screen
end
function exec(cmd)
local f = assert(io.popen(cmd, 'r'))
local s = assert(f:read('*a'))
f:close()
return trim1(s)
end
function trim1(s)
return (s:gsub("^%s*(.-)%s*$", "%1"))
end
local function tagger(event)
local path_prop = "stream-open-filename" -- "path"
local path = mp.get_property(path_prop)
local cwd = utils.getcwd()
if path == nil or cwd == nil then
do return end
end
local abs_path = utils.join_path(cwd, path) -- @todo0 check if path is actually relative or not. path is the same as the cli arg.
local new_path = (exec(("brishzq.zsh ntag-add-givedest %q green"):format(abs_path)))
log("Greened: " .. new_path)
mp.set_property(path_prop, new_path) -- doesn't work https://github.com/mpv-player/mpv/issues/8154
mp.set_property("path", new_path)
function mg(event)
mp.unregister_event(mg)
log("end-file's reason: " .. event["reason"])
if event["reason"] == "eof" or event["reason"] == "stop" then
log(exec(("brishzq.zsh greens2teal %q"):format(new_path)))
else
log(exec(("brishzq.zsh green2aqua %q"):format(new_path)))
end
end
mp.register_event("end-file", mg)
end
mp.register_event("file-loaded", function() log("Updated path: " .. mp.get_property("path")) end)
mp.add_hook("on_load", 0, tagger)@CogentRedTester commented on Oct 8, 2020, 5:52 PM GMT+3:30:
I don't quite understand what you're trying to accomplish, but you probably want to be editting the stream-open-filename property during an on_load hook. Use mp.add_hook
Thanks, I think I solved my problem:
local function load_renamer(hook)
local path_prop = "stream-open-filename"
local path = mp.get_property(path_prop)
local cwd = utils.getcwd()
if path == nil or cwd == nil then
do return end
end
-- @weird According to the doc, the path is the same as the cli arg. So why is this working with absolute path args?!
local abs_path = utils.join_path(cwd, path)
local new_path = (exec(("brishzq.zsh ntag-recoverpath %q"):format(abs_path)))
if not (abs_path == new_path) then
log("load_renamer's new path: " .. new_path)
end
mp.set_property("stream-open-filename", new_path)
end
mp.add_hook("on_load", 0, load_renamer)@CogentRedTester commented on Oct 8, 2020, 5:52 PM GMT+3:30:
I don't quite understand what you're trying to accomplish, but you probably want to be editting the stream-open-filename property during an on_load hook. Use mp.add_hook
Is there any way I can make the watch_later machinery also respect the new path?
CogentRedTester
commented
3 years ago At that point I think you'll need to actually replace the playlist entry. What you'll need to do is, during the on_load hook, append a new file (the new path) to the end of the playlist, move it to after the current entry, then remove the current entry. This will automatically start playback of the new file, which is pretty seamless if you do it during the hook.
I have a lua script that automatically tags playing files by adding
..green..to their filename, and tags played file by removing..green..and adding..teal... The problem is that I can't get mpv to play nicely with its playing file being renamed. I have usedmp.set_property("path", new_path)to no avail.Here is the script:
Log file