search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
26.75k stars 2.84k forks source link

quit command stops but doesn't quit in encoding mode (--o=...) #8754

Open twilson90 opened 3 years ago

twilson90 commented 3 years ago

Important Information

Provide following Information:

Reproduction steps

Start mpv in encoding mode and encode a playlist of media files. Either setup a timed event in a lua script or issue a command via IPC to quit after approximately 1 minute.

Expected behavior

mpv should immediately quit.

Actual behavior

mpv stops but does not quit, process stays alive.

Log file

Log file provides no clues. In this example I send the quit command at approx 10 seconds, but nothing is recorded in the log:

mpv-2021-03-19-10-43-49-71.log

Note - the log file uses a custom build of mpv but the results are identical in the latest release. I've noticed this bug since I began using mpv for encoding (since March 2020 builds, this problem likely has been around for much longer)

mia-0 commented 3 years ago

This is likely working as intended. mpv will process what’s left in the encoder buffers and close the stream container. The FFmpeg command line tool does the same thing. If it didn’t do this, it could generate unplayable files, especially with e.g. ISO BMFF (.mp4) and default options.

It should exit eventually, though.