screenshots are calibrated, other apps will calibrate it again

natural-harmonia-gropius commented 3 years ago

Important Information

Provide following Information:

mpv version 0.33.0
Platform and Version Win11
Source of the mpv binary shinchiro

Reproduction steps

async screenshot video

Expected behavior

screenshots without calibration

Actual behavior

take a screenshot with icc-profile-auto=no open it with any photoviewer support calibrate. (mpv with icc-profile-auto=yes, or chrome) set icc-profile-auto to yes in mpv (video) both display same color

take a screenshot with icc-profile-auto=yes open it with any photoviewer support calibrate. (mpv with icc-profile-auto=yes, or chrome) it was recalibrated, background turns purple

Sample files

icc-profile-auto=no 2002 5 生命之书 -Akashic Record- mp4-00_37_14 257-0002 icc-profile-auto=yes icc-profile-auto=yes > async screenshot video > icc-profile-auto=yes

natural-harmonia-gropius commented 2 years ago

Closed. because looks not easy to implement, and not that useful https://github.com/mpv-player/mpv/pull/9518

haasn commented 2 years ago

Hi, the correct solution for this would be to attach the ICC profile of the display to the generated screenshot files. This is totally doable, but relies on FFmpeg support for encoding ICC profiles into jpgs/pngs respectively. (Which I think it can, but need to double check)

Reopening because I think this is a valid bug with a clear solution.

mpv-player / mpv