search

mpvnet-player / mpv.net

🎞 mpv.net is a media player for Windows with a modern GUI.
GNU General Public License v2.0
3.59k stars 164 forks source link

Config editor deletes user defined settings in mpv.conf whenever it writes to the file #538

Open radonmiser opened 1 year ago

radonmiser commented 1 year ago

Describe the bug Config editor deletes user defined settings in mpv.conf whenever it writes to the file. This causes problems when user wishes to use options not available in the config editor, such as --no-border at the startup. To Reproduce

  1. Go to mpv.conf
  2. append no-border to mpv.conf
  3. save and the settings works, player starts in no-border mode.
  4. open the config editor and change any settings.
  5. no-border is gone and the player starts with border

Expected behavior User defined settings are preserved. Maybe a field in the config editor where users can append settings that's won't be deleted. Additional context Add any other context about the problem here.

  1. mpv.net version : 6.0.3.0
  2. Windows version : win10
stax76 commented 1 year ago

mpv might support various uncommon syntax variations, mpv.net understands only the most common syntax:

border = yes border = no

radonmiser commented 1 year ago

@stax76 Can you please reopen this? The issue is about the GUI settings editor not respecting any option that's not originated from the GUI editor. It straight up deletes those every time you use the GUI editor. (including the border = yes border = no you provided)

I'm proposing a field to be added to the GUI editor that the user can input anything and won't get deleted after every GUI editor use.