search

mpyw / axios-case-converter

Axios transformer/interceptor that converts snake_case/camelCase
MIT License
160 stars 18 forks source link

Update axios dependency to 0.21.1 #34

Closed davidfishlock closed 3 years ago

davidfishlock commented 3 years ago

Addresses a high severity security advisory on axios peer dependency: https://www.npmjs.com/advisories/1594

mpyw commented 3 years ago

Build seems to be failing 😢 Duplicates of #33 (But I don't close any PR until one of them is merged)

davidfishlock commented 3 years ago

@mpyw the build failures are unrelated to this PR. All builds on this repository will have been failing since 20th October, when node 15 became the stable version.

The Travis config runs against two node versions:

The build is failing on node 15 because the test run is generating unhandled promise rejections. You can see these in the log output for build runs of the last successful PR on this repo:

(node:6693) UnhandledPromiseRejectionWarning: Error: EBADF: bad file descriptor, close

The difference in node 15 is that these unhandled promise rejections will terminate the process. So currently any build on this repo will be passing on node < 15 and failing on node 15+.

I can't reproduce these file descriptor failures locally, this could be something specific to the Travis or linux environment and/or something specific to the way the tests are being set up.

These will either need to be fixed for any future PRs to pass on this repo, or the Travis runs will need to stop running on node 15.

mpyw commented 3 years ago

Fix CI builds · Issue #35 · mpyw/axios-case-converter