Answers for #39 and #40

[mpyw]

Answers for #39 and #40

I'm sorry that I'm not willing to implement these features now. I'll explain some reasons. See also the following implementation for reference.

export const applyCaseMiddleware: ApplyCaseMiddleware = (axios, options?) => {
  axios.defaults.transformRequest = [
    options?.caseMiddleware?.requestTransformer ||
      createSnakeRequestTransformer(options),
    ...(Array.isArray(axios.defaults.transformRequest)
      ? axios.defaults.transformRequest
      : axios.defaults.transformRequest !== undefined
      ? [axios.defaults.transformRequest]
      : []),
  ];
  axios.defaults.transformResponse = [
    ...(Array.isArray(axios.defaults.transformResponse)
      ? axios.defaults.transformResponse
      : axios.defaults.transformResponse !== undefined
      ? [axios.defaults.transformResponse]
      : []),
    options?.caseMiddleware?.responseTransformer ||
      createCamelResponseTransformer(options),
  ];
  axios.interceptors.request.use(
    options?.caseMiddleware?.requestInterceptor ||
      createSnakeParamsInterceptor(options)
  );
  return axios;
};

Interceptor

According to the Official Documentation, you can manually apply interceptor like this:

axios.interceptors.request.use(
  options?.caseMiddleware?.requestInterceptor ||
    createSnakeParamsInterceptor(options),
  null,
  { runWhen(config) { /* ... */ } }
);

With this feature, it is possible to implement it on the library side. But I'm not willing to do so because it is difficult to achieve the same functionality on Transformer and it also looks unstable.

• third parameter of interceptors.request.use not work · Issue #3736 · axios/axios

Transformer

The implementation in Transformer corresponding to the Interceptor checking runWhen() is the following part.

• https://github.com/axios/axios/blob/1025d1231a7747503188459dd5a6d1effdcea928/lib/core/transformData.js#L17-L19

It looks quite difficult to determine the URL in this layer since request config is not given as an argument here.

Conclusion

The current best practice is:

• Wrap different Axios instances with your own wrapper function.
• Decide which Axios instance to use by the the argument condition.