search

mqchen / jquery.diamonds.js

Diamond layout.
http://mqchen.github.io/jquery.diamonds.js/
MIT License
128 stars 69 forks source link

Layout issue #8

Closed bkhoo closed 10 years ago

bkhoo commented 10 years ago

Hi Moquan,

This is Boon, I contacted you on twitter about your plugin. Once again thanks for making the plugin, it's really cool. I'm using it to build my portfolio site and it's been super helpful. Everything was working fine until yesterday when Chrome just crapped out. I'm not sure if Google made some changes to Chrome.

Something odd is happening with the way the diamonds are wrapping. It seems like the div containing them is too small and its causing the diamond row to break prematurely and create scroll bars for the overflow. This only happens with chrome. Firefox, IE, and Safari are fine. I checked your plugin demo and the same thing is happening there so I don't think it's something I did. If you can provide any kind of help it would greatly be appreciated. I was so close to finishing my site! :( I've provided a screenshot of what's happening and the link to my site as well. Thanks so much for your response! You can also email at bkhoo76@gmail.com

www.boon.dudlyboys.com

screen shot 2014-02-22 at 9 49 05 am

bkhoo commented 10 years ago

Hi Moquan,

I'm not sure if this is the correct solution, but I was playing around with the stylesheet and tweaked it a little and it seems to work on chrome now. It's working on other browsers too. Hopefully this is enough and I'm not breaking it somewhere else by doing so. Fingers crossed.

.diamond-row-upper, .diamond-row-lower { /overflow:auto; I changed overflow to none/ overflow: none; clear: both; width: 100%; }

mqchen commented 10 years ago

Hi! Your site looks good in my Chrome 32 on OS X. Are you sure you don't have an extension that might be interfering?

PS. overflow: none is not valid css. You could use overflow: visible instead.

screen shot 2014-02-22 at 22 09 43

bkhoo commented 10 years ago

Hi Moquan,

Thanks for the reply. Ya I changed the overflow property in the CSS and that seemed to fix the issue in chrome. I'm glad it was only a CSS issue. I wonder what happened with Chrome that altered the layout since things were working before. Are you a web developer full time?

Cheers, Boon On Feb 22, 2014, at 4:12 PM, mqchen wrote:

Hi! Your site looks good in my Chrome 32 on OS X. Are you sure you don't have an extension that might be interfering?

PS. overflow: none is not valid css. You could use overflow: visible instead.

— Reply to this email directly or view it on GitHub.

mqchen commented 10 years ago

Hi! Glad it worked out. Just re-open the issue if you encounter the problem again.

(Nice logo animation by the way)