search

mqtt-tools / mqttwarn

A highly configurable MQTT message router, where the routing targets are notification plugins, primarily written in Python.
https://mqttwarn.readthedocs.io/
Eclipse Public License 2.0
950 stars 183 forks source link

[APNS] Migrate to `apns2` or `aioapns` #580

Open amotl opened 1 year ago

amotl commented 1 year ago

Hi there,

@LaborEtArs asked at https://github.com/jpmens/mqttwarn/issues/396#issuecomment-575877788:

Are there plans to update the apns plugin to apns2?

apns did not receive any updates since 2015, apns2 does a better job here, the most recent release is from 2020. So, indeed, the plugin should be updated accordingly.

With kind regards, Andreas.

amotl commented 1 year ago

On the issue tracker of the PyAPNs2 repository, I found those:

Because of that, it looks like some other projects switched to the aioapns library in the meanwhile. We should probably do the same.

amotl commented 1 year ago

Dear @LaborEtArs,

if this can spark your interest, we will be very happy to receive corresponding patches in order to be able to support the Apple Push Notification service again. Based on my research, I think using the aioapns library would be the right choice today.

With kind regards, Andreas.

amotl commented 1 year ago

I've also just evaluated apns2, but it will not work on Python3.11 until the issues referenced at https://github.com/jpmens/mqttwarn/issues/580#issuecomment-1222093678 got resolved. There is progress on this now at https://github.com/Pr0Ger/PyAPNs2/pull/149, thanks to @salty-horse.