search

mqtt-tools / mqttwarn

A highly configurable MQTT message router, where the routing targets are notification plugins, primarily written in Python.
https://mqttwarn.readthedocs.io/
Eclipse Public License 2.0
950 stars 183 forks source link

Documentation: Notifier catalog copyediting and spring cleaning I #648

Closed amotl closed 1 year ago

amotl commented 1 year ago

Following up on the documentation backlog items (https://github.com/jpmens/mqttwarn/issues/389#issuecomment-1516686917), I've dissolved a few Wiki pages, sparking this copyedit patch to the notifier catalog. While working on it, the patch also dissolves the gss plugin (GH-647).

There will probably be a few other followup patches to this one, in order to dissolve the Wiki pages completely.

codecov-commenter commented 1 year ago

Codecov Report

Merging #648 (3fecc08) into main (2756244) will increase coverage by 0.37%. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   45.77%   46.15%   +0.37%     
==========================================
  Files          81       80       -1     
  Lines        3945     3913      -32     
==========================================
  Hits         1806     1806              
+ Misses       2139     2107      -32
Flag Coverage Δ
unittests 46.15% <ø> (+0.37%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

amotl commented 1 year ago

Dear @jpmens, and @sumnerboy12,

both of you recently added your acknowledgements to one of my patches, so I thought you might be interested in further updates to the code base, and tried to improve by chunking patches into different PRs, to make them easier to review.

On the other hand, I don't want to steal your precious time by asking to review tedious and boring maintenance patches. On the other hand again, it might be that you have valuable things to suggest.

If I don't hear back from you, I may continue merging this and the other pending patches. I hope you will not mind too much then.

With kind regards, Andreas.

amotl commented 1 year ago

Thanks for reviewing all my patches!