search

mqtt-tools / mqttwarn

A highly configurable MQTT message router, where the routing targets are notification plugins, primarily written in Python.
https://mqttwarn.readthedocs.io/
Eclipse Public License 2.0
950 stars 183 forks source link

A bit of core sanding (80-100) #659

Closed amotl closed 1 year ago

amotl commented 1 year ago

Sleeves up. After all the documentation improvements, this patch aims to sand a few edges, and to bring code coverage for the mqttwarn core machinery to ~100%, increasing the coverage for mqttwarn.core itself by 7.5%.

image

codecov-commenter commented 1 year ago

Codecov Report

Merging #659 (3cbed84) into main (d27e982) will increase coverage by 1.35%. The diff coverage is 98.14%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   46.58%   47.94%   +1.35%     
==========================================
  Files          80       81       +1     
  Lines        3913     3917       +4     
==========================================
+ Hits         1823     1878      +55     
+ Misses       2090     2039      -51
Flag Coverage Δ
unittests 47.94% <98.14%> (+1.35%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mqttwarn/__init__.py 100.00% <ø> (ø)
mqttwarn/core.py 99.55% <96.87%> (+7.48%) :arrow_up:
mqttwarn/configuration.py 100.00% <100.00%> (+1.69%) :arrow_up:
mqttwarn/context.py 100.00% <100.00%> (+0.76%) :arrow_up:
mqttwarn/model.py 100.00% <100.00%> (+1.49%) :arrow_up:
mqttwarn/services/noop.py 100.00% <100.00%> (ø)
mqttwarn/util.py 100.00% <100.00%> (+1.47%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more