mqtt-tools / mqttwarn

A highly configurable MQTT message router, where the routing targets are notification plugins, primarily written in Python.
https://mqttwarn.readthedocs.io/
Eclipse Public License 2.0
955 stars 183 forks source link

[Pushbullet]: Modernize service plugin #676

Closed amotl closed 1 year ago

amotl commented 1 year ago

About

Modernize Pushbullet service plugin.

Details

References

Resources

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.93 :tada:

Comparison is base (288392f) 47.94% compared to head (93d65bf) 48.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #676 +/- ## ========================================== + Coverage 47.94% 48.88% +0.93% ========================================== Files 81 81 Lines 3917 3938 +21 ========================================== + Hits 1878 1925 +47 + Misses 2039 2013 -26 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `48.88% <100.00%> (+0.93%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mqtt-tools#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/mqtt-tools/mqttwarn/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mqtt-tools) | Coverage Δ | | |---|---|---| | [mqttwarn/services/pushbullet.py](https://app.codecov.io/gh/mqtt-tools/mqttwarn/pull/676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mqtt-tools#diff-bXF0dHdhcm4vc2VydmljZXMvcHVzaGJ1bGxldC5weQ==) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

DNicholai commented 1 year ago

Dear Andreas, Dear all,

I've just tested this and I can confirm it's working, thank you so much ^^

I am running the following command :

sudo docker run --rm -it --name=mqttwarn_test --volume=$PWD:/etc/mqttwarn ghcr.io/mqtt-tools/mqttwarn-standard:pr-676 mqttwarn

/!\ -- Quick note for any users following at home : The command which worked for me is slightly different than the command as suggested above as I am not using the appended version specifier. I suspect it defaults to the correct version. Notably, I am not appending the portion in bold

sudo docker run --rm -it --name=mqttwarn_test --volume=$PWD:/etc/mqttwarn ghcr.io/mqtt-tools/mqttwarn-standard:pr-676 mqttwarn --version mqttwarn 0.34.1.post5+gf4a6a9e.d20230523

I confirm as well that once configured, this setup gives successful pushes to my pushbullet client.

BR, David

amotl commented 1 year ago

Hi David,

thanks a stack for your positive response. So, when there are no other objections, let's merge this improvement.

With kind regards, Andreas.