Closed amotl closed 8 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
6a24a8a
) 49.33% compared to head (731afef
) 49.51%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Great job! I was looking forward to this release. Thanks! :-)
Wonderful. If this works now, we can close GH-677?
/cc @zoic21
Dear @codebude and @zoic21,
this patch has been grown in July already, but only now I have been able to wrap it up. It is based on the suggestion by @codebude shared at https://github.com/mqtt-tools/mqttwarn/issues/677#issuecomment-1575060446, thank you very much.
With kind regards, Andreas.
P.S.: I will be happy about a review, both on code and/or functionality, either before, or after merging and releasing. If it's about code, commenting on this PR will be the appropriate spot. If it is about the outcome, I'd say we just continue our conversation at GH-677, independently of this PR.