mqtt-tools / mqttwarn

A highly configurable MQTT message router, where the routing targets are notification plugins, primarily written in Python.
https://mqttwarn.readthedocs.io/
Eclipse Public License 2.0
950 stars 183 forks source link

Core: Fix decoding non-JSON messages, negatively impacting templating #686

Closed amotl closed 8 months ago

amotl commented 8 months ago

About

This patch fixes a message decoding/re-encoding error reported by @Sc0th.

codecov[bot] commented 8 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (6a24a8a) 49.33% compared to head (551139e) 49.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #686 +/- ## ========================================== + Coverage 49.33% 49.37% +0.03% ========================================== Files 81 81 Lines 3973 3976 +3 ========================================== + Hits 1960 1963 +3 Misses 2013 2013 ``` | [Flag](https://app.codecov.io/gh/mqtt-tools/mqttwarn/pull/686/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mqtt-tools) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/mqtt-tools/mqttwarn/pull/686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mqtt-tools) | `49.37% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mqtt-tools#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/mqtt-tools/mqttwarn/pull/686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mqtt-tools) | Coverage Δ | | |---|---|---| | [mqttwarn/core.py](https://app.codecov.io/gh/mqtt-tools/mqttwarn/pull/686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mqtt-tools#diff-bXF0dHdhcm4vY29yZS5weQ==) | `99.55% <100.00%> (+<0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.