Closed otdftr closed 5 months ago
Attention: 12 lines
in your changes are missing coverage. Please review.
Comparison is base (
9d61fc5
) 49.75% compared to head (aac55eb
) 49.60%.:exclamation: Current head aac55eb differs from pull request most recent head 675fbb0. Consider uploading reports for the commit 675fbb0 to get more accurate results
Files | Patch % | Lines |
---|---|---|
mqttwarn/services/http_urllib.py | 0.00% | 12 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
this one had two bugs, creating new PR
When working with a greater number of transformed fields (e. g. through topic's alldata), the params definition for the target has a lot of redundancy, especially when the field names are crafted to be the parameter names of the query parameters:
This patch provides a shorthand for a definition like
[ #method, #url, { 'param1' : '@param1', ..., 'paramN': '@paramN' }, ...
by allowing lists for the 3rd parameter of the target definition:[ #method, #url, [ '?param1', ..., '?paramN' ], ...
If a list is provided
[ 'param1', ..., 'paramN' ]
will be interpreted as[ '@param1', ..., '@paramN' ]
?
, fields can be declared optional: they will not be included in the query if the data is invalid or missing from item.data{};[ 'param1', '?param2', ... ]