search

mqttjs / MQTT.js

The MQTT client for Node.js and the browser
Other
8.58k stars 1.42k forks source link

Integration tests on Github Actions for all OSS brokers #505

Closed mcollina closed 2 years ago

mcollina commented 7 years ago

It would be awesome to receive a contribution to do some integration testing against the major OSS brokers.

Something using Travis ENV support, or similar. It might even be a separate repo, feel free to discuss!

ralphtheninja commented 7 years ago

@mcollina Do we have any integration tests implemented?

mcollina commented 7 years ago

zero. But I think we should.

sandro-k commented 7 years ago

I am on board.. Lets start with something simple like Mosca and expand from there.

mcollina commented 7 years ago

I have no time to coordinate this :(. I would suggest we should start with Mosquitto and Mosca. Please go ahead and do it, I will be happy to review.

4rzael commented 7 years ago

I completely agree on this. I don't have time to help right now, but I'll be happy to do so when possible.

sandro-k commented 7 years ago

I am trying to free some time next week.

anhldbk commented 7 years ago

Would you guys elaborate more on how we take integration tests? I think we should make a to-do list now. For example:

sandro-k commented 7 years ago

Thanks @anhldbk for getting this started again.

Brokers

What to test

Platform

EDIT I am updating this list with information that are posted in the comments below..

anhldbk commented 7 years ago

Currently, I am using emq broker and find it great. It's written in Erlang (suitable for production environments).

About What to test, should we have tests for MQTT Over WebSocket?

mcollina commented 7 years ago

@anhldbk I think so, yes.

mcollina commented 7 years ago

It would be awesome to have integration tests also via SauceLabs.

anhldbk commented 7 years ago

The integration test results should be organized into a report with:

  1. Information about brokers
  2. For each broker, we should have describe the running environment. It must be reproducible. (Docker may be a great relief)
  3. Associated test scripts
  4. Finally, a summary

@sandro-k , @mcollina is that ok?

mcollina commented 7 years ago

@anhldbk yes! Go ahead and make it docker-based.

Bonus points (but keep it separate): websockets in browsers.

YoDaMa commented 4 years ago

changed the name since this is still a relevant ask but we're using Github Actions now.

github-actions[bot] commented 2 years ago

This is an automated message to let you know that this issue has gone 365 days without any activity. In order to ensure that we work on issues that still matter, this issue will be closed in 14 days.

If this issue is still important, you can simply comment with a "bump" to keep it open.

Thank you for your contribution.

github-actions[bot] commented 2 years ago

This issue was automatically closed due to inactivity.