search

mqttjs / async-mqtt

Promise wrapper over MQTT.js
MIT License
272 stars 50 forks source link

support for mqtt 3+ #20

Closed dkebler closed 5 years ago

dkebler commented 5 years ago

Currently async-mqtt support 2+. 

 "dependencies": {
    "mqtt": "^2.3.1"
},

mqtt 3+ has been out for month anything in the works for async-mqtt to support that release? I haven't looked but it may not need anything more than to bump the version in package.json?

RangerMauve commented 5 years ago

I'm not sure what'd be required. Would you happen to have time to take a shot at a PR for it? :D

dkebler commented 5 years ago

Just for grins I simply upgraded the mqtt dep and it passed your test so maybe nothing to do.

I've actually gone another direction with mqtt bending it into es6 with async methods including a connect method (which in mqtt creates the client instance). Referring to your source made that easier so thx. https://git.kebler.net/UCOMmandIt/uci-mqtt/src/branch/master/src/mqtt.js

RangerMauve commented 5 years ago

Sweet. Glad that worked out for you. I'm gonna close this for now. Feel free to reopen if there are still issues. 😁