search

mqttjs / mqtt-packet

Parse and generate MQTT packets like a breeze in JS
Other
206 stars 93 forks source link

Fix Buffer Out of Bounds Error #100

Closed bkp7 closed 3 years ago

bkp7 commented 3 years ago

Fix bug in _parseVarByteNum() function causing Buffer Out of Bounds Error.

Added Tests.

Also refactored the testParseGenerateDefaults() test function to separate out a new testParseOnly() which can be used directly.

Fixes #99, fixes #98, closes #78, fixes mqttjs/MQTT.js#1073, fixes mqttjs/MQTT.js#993, fixes mqttjs/MQTT.js#1176

Possible fix to mqttjs/MQTT.js#1228 which has this function in the call stack. Unfortunately no specific test provided in that issue to prove it's fixed.

Probable fix to #72, but gist and test not longer present to check it.