search

mqttjs / mqtt-packet

Parse and generate MQTT packets like a breeze in JS
Other
206 stars 93 forks source link

fix: IUnsubackPacket types definition #144

Closed ogis-yamazaki closed 1 year ago

ogis-yamazaki commented 1 year ago

The implementation sets GRANTED in response to unsuback.

https://github.com/mqttjs/mqtt-packet/blob/ec5ad06d96192d8d9bcbe551c12df802aa38a33a/parser.js#L489

However, it is not present in the type definition of IUnsubackPacket.

https://github.com/mqttjs/mqtt-packet/blob/ec5ad06d96192d8d9bcbe551c12df802aa38a33a/types/index.d.ts#L160-L167

I made a PR, please check it out.

robertsLando commented 1 year ago

@mcollina Could you do a patch release please?

robertsLando commented 1 year ago

@mcollina Ping