search

mquan / lavish

a rails app that generates Bootstrap color scheme from an image
http://lavishbootstrap.com/
694 stars 92 forks source link

.modal position off screen #22

Closed LouisMilotte closed 9 years ago

LouisMilotte commented 10 years ago

On line 4954~ for media selector screen width 768px

.modal-dialog is positioned to the left by 50%. This by default pushes navigation based triggers off screen (if right navigation). The default should be left:0; to resolve. The purpose of a modal is to bring absolute attention to the event; thus, overlapping all content.

mquan commented 9 years ago

I'm not sure if this is introduced by lavish. Lavish only alters the colors in variables section and does not touch anything else.

LouisMilotte commented 9 years ago

This does happen in lavish as the CSS declaration above is within the lavish generated file.

mquan commented 9 years ago

Yes, lavish generates the css/less file but it only touches the color variables. So whatever unexpected behavior that isn't color related is a possible bug in bootstrap 3.0