mquandalle / meteor-bower

[DEPRECATED] Use bower packages in your Meteor app
http://bower.io/search/
MIT License
157 stars 28 forks source link

Bower dependencies list must be a dictionary #107

Closed kristijanhusak closed 3 years ago

kristijanhusak commented 8 years ago

I get these errors when I install some packages:

While building the application:
   error: Bower dependencies list must be a dictionary in
   client/bower_components/inuit-box-sizing/bower.json
   error: Bower dependencies list must be a dictionary in
   client/bower_components/inuit-clearfix/bower.json
   error: Bower dependencies list must be a dictionary in
   client/bower_components/inuit-defaults/bower.json
   error: Bower dependencies list must be a dictionary in
   client/bower_components/inuit-functions/bower.json
   error: Bower dependencies list must be a dictionary in
   client/bower_components/inuit-images/bower.json
   error: Bower dependencies list must be a dictionary in
   client/bower_components/inuit-normalize/bower.json
   error: Bower dependencies list must be a dictionary in
   client/bower_components/inuit-print/bower.json
   error: Bower dependencies list must be a dictionary in
   client/bower_components/inuit-reset/bower.json
   error: Bower dependencies list must be a dictionary in
   client/bower_components/inuit-responsive-settings/bower.json
   error: Bower dependencies list must be a dictionary in
   client/bower_components/jquery/bower.json
   packages/bower/plugin/handler.js:209:1: Cannot read property 'name' of
   undefined (compiling client/bower_components/jquery/bower.json)
   at getDependencies (packages/bower/plugin/handler.js:209:1)
   at packages/bower/plugin/handler.js:220:1
   at Function._.each._.forEach
   (packages/underscore/packages/underscore.js:142:1)
   at getDependencies (packages/bower/plugin/handler.js:219:1)
   at bowerHandler (packages/bower/plugin/handler.js:76:1)
   at Package (packages/bower/plugin/handler.js:262:1)

As i noticed, you are enforcing each bower package to have dependencies key in their bower.json here: https://github.com/mquandalle/meteor-bower/blob/76057de9be304afb3e71097cf417efca44f2513f/plugin/handler.js#L20

Why is that required?

Also, as you can see in the errors above, exception is thrown for jquery that name cannot be read, but it exists and should be readable. Jquery is in ignoredDepencencies in bower.json, but that shouldn't throw an exception for something like this.

lorensr commented 8 years ago

Why is that required?

Sorry, don't know.