search

mquandalle / meteor-bower

[DEPRECATED] Use bower packages in your Meteor app
http://bower.io/search/
MIT License
157 stars 28 forks source link

Specific issue with iNoBounce not loading onto client #72

Closed lourd closed 9 years ago

lourd commented 9 years ago

I'm trying to include the iNoBounce library with this package. It's a small, straightforward library — barely over 100 lines. It's not published on the public bower repository so I include it with

{
  "name": "scratch",
  "dependencies" : {
    "inobounce": "https://github.com/lazd/iNoBounce.git"
  }
}

The package downloads it into .meteor/local/bower just fine... but then it never gets loaded onto the client. It's nowhere to be found in the build.

Here is a vanilla Meteor application demonstrating this. I've gone through the iNoBounce code thoroughly and don't believe that it contains anything that would prevent it from being loaded. My hunch would be that something with its bower.json file is wrong and causing the behavior but I'm not sure how to debug that more. Any help is appreciated!

lorensr commented 9 years ago

inobounce doesn't have a bower.json, solution is https://github.com/lourd/bower-issue/pull/1

lorensr commented 9 years ago

thanks for the repro, this one was new to me :)

lourd commented 9 years ago

Nice, that was simple. I'm still a little confused though. iNoBounce does have a bower.json file. Why is it not processed?

lorensr commented 9 years ago

Oh! Sorry, I was going by what was in .meteor/local/bower. Looks like meteor-bower was installing the only version tagged in that repo, which was v0.1, which doesn't have the file. You can point it to master like this:

"inobounce": "https://github.com/lazd/iNoBounce.git#master"

lourd commented 9 years ago

Ohhhhhh very interesting, nice catch! So not putting a location defaults to the last tag and not master, got it.