search

mquekel / vsts-ip-restrictions

Add or remove IP Restrictions, use custom address or add the IP of the build agent.
1 stars 5 forks source link

Restrictions are added but not 'activated' #4

Closed rdeveen closed 5 years ago

rdeveen commented 5 years ago

The script is working, the IP restrictions are added and are visible in the Azure Portal but the restrictions are not working. When adding new restrictions in the portal, the already existing restrictions are activated and working.

Maybe this is an issues with not using the latest version of the API? Can you update the task?

mquekel commented 5 years ago

Thanks for your comment. It has been a while since I have last updated this project. I will have a look at it and let you know!

equalizer999 commented 5 years ago

OK, looks like the input for adding the IP addresses (including the range) is corrupting the complete functionality in the appservice :(. We added '1.1.1.1/1 API-management' from an Azure Pipeline which was successfully processed by the script and accepted as valid values in Azure. Just added '1.1.1.1' did the trick for getting it to work. Something to check; does a higher API version also have this behavior..?

mquekel commented 5 years ago

Thanks for the advide @rdeveen @equalizer999. I fixed the issue by using the latest version of the API. I upgraded the version to 3.0. If you want to use this new version, don't forget to upgrade the Version in your Azure Devops pipeline.