search

mquekel / vsts-ip-restrictions

Add or remove IP Restrictions, use custom address or add the IP of the build agent.
1 stars 5 forks source link

Adding comma for separator #7

Closed juteasl closed 5 years ago

juteasl commented 5 years ago

Adding the ability to use a comma as a separator instead of just a newline

mquekel commented 5 years ago

Hello and thank you for creating the pull request, I will have test this out tonight and create a new version soon after that.

mquekel commented 5 years ago

Thank you for your contribution to this extension. the code is merged and I a new version (3.1.0) is available.

jmereaux commented 5 years ago

Not 100% sure but seems like this feature introduced a wrong behavior for me.

Before the patch, the following used to work fine:

x.x.x.x/32 Subnet 1
y.y.y.y/32 Subnet 2
z.z.z.z/32 Subnet 3

With the new version, only the rule for Subnet1 is created

Any idea on what I'm missing. Thanks