search

mquinson / po4a

Maintain the translations of your documentation with ease (PO for anything)
http://po4a.org/
GNU General Public License v2.0
127 stars 62 forks source link

HTML test does no longer pass #146

Closed sergiomb2 closed 6 years ago

sergiomb2 commented 6 years ago

From po4a-0.54/debian/rules [1] notice that after same problem on packing it on Fedora ... rm t/09-html.t also fixes the build for me .

[1] 

# Remove HTML test, which does no longer pass
# and probably should be removed upstream, too.
override_dh_auto_test:
    rm t/09-html.t
mquinson commented 6 years ago

This is new to me. @toddy15 could you please explain what the problem is/was?

I see that it was changed in https://github.com/mquinson/po4a/commit/db150b8a89fa3bbe8c7bd5077aac572e9b438a2b but the module is still there: https://github.com/mquinson/po4a/blob/master/lib/Locale/Po4a/Html.pm

If it's obsolete, shouldn't we remove the module all together, and not only its tests? I'm definitely missing something here :)

Thanks for your work on the po4a beast,

toddy15 commented 6 years ago

Yes, it's probably best to remove the module as well. After all, it was never part of the po4a tarballs, only in the VCS. I've now removed the module as well -- if you don't agree, please feel free to revert this commit: f8b5288

However, I think we should remove the module, because it's not mature enough and could be easily restored from git, if somebody would like to resume the work.

toddy15 commented 6 years ago

... oh, by the way, there are two other modules as well: NewsDebian.pm and Debconf.pm. Both are only in git, not in the tarballs -- should they be removed as well?

mquinson commented 6 years ago

I completely agree that html should be removed since it is superseeded by xhtml that should work (shouldn't it?).

As for NewsDebian, uhh. It seems that I wrote this 13 years ago :-X I don't remember at all about it... That's a good idea, I should probably make it work at some point. What about moving it to a b0rken/ directory instead of killing it right away?

And Debconf is more complicated. The TransTractor is not enough for this format because all the languages are set in the same translated document. We'd need a way for the formats to say "loop over all languages" or something. Same thing, I'd like to keep this file around, but not with the other modules.

Would you mind if we keep them around?

toddy15 commented 6 years ago

Certainly not, that's not my call to make. So we'll leave them just in the place where they are. They are in git, but not included in the tarballs. Seems good enough for me. :-)

mquinson commented 6 years ago

Ok, I moved the 2 remaining modules out of the way, which, I think, is enough to close this issue. If you disagree, feel free to reopen.

Thanks a lot,