mquinson / po4a

Maintain the translations of your documentation with ease (PO for anything)
http://po4a.org/
GNU General Public License v2.0
127 stars 62 forks source link

please credit me for my contributed markdown parser #158

Closed jonassmedegaard closed 5 years ago

jonassmedegaard commented 5 years ago

Hi,

Many years ago I contributed the markdon mode of the Text parser to this project. I notice now that I am not credited for that, and would appreciate if that would be corrected (blame is arguably on myself of not including a copyright statement in my contributed patches back then).

E.g. adopt this: https://salsa.debian.org/js/po4a/commit/28ae7e4

mquinson commented 5 years ago

Hello Jonas,

I'm really sorry to learn that I forgot to credit you for your work. Please be assured that this is a stupid mistake from my side, not a decision. The URL that you give is a 404 here, but that's not important. I feel stupid for my mistake.

Could you please prepare a PR that we could use to close this issue?

Thanks in advance, Mt

jonassmedegaard commented 5 years ago

Quoting Martin Quinson (2018-11-01 18:12:49)

I'm really sorry to learn that I forgot to credit you for your work. Please be assured that this is a stupid mistake from my side, not a decision. The URL that you give is a 404 here, but that's not important. I feel stupid for my mistake.

Could you please prepare a PR that we could use to close this issue?

As I wrote before, no blame here: I provided a patch which it seems passed through multiple hands before it landed in the project.

I am just happy to have this corrected now that I pour a bit of attention to it myself again :-)

Access to the git should work now.

--

toddy15 commented 5 years ago

Hi,

I've cherry-picked the commit from your repository on salsa.d.o.

Regards, Tobias

jonassmedegaard commented 5 years ago

Quoting Dr. Tobias Quathamer (2018-11-03 13:45:20)

I've cherry-picked the commit from your repository on salsa.d.o.

Thanks!

I'll then drop that and replace with my markdown changeset.

--