search

mquinson / po4a

Maintain the translations of your documentation with ease (PO for anything)
http://po4a.org/
GNU General Public License v2.0
124 stars 61 forks source link

Asciidoc: Don't split in attributes include:: and ifeval:: lines #298

Closed dbaio closed 3 years ago

dbaio commented 3 years ago

Issue summary:

    # | -ifeval::["{foo}" == "bar"]
    # | -include::{foo-path}bar.adoc[leveloffset=+1, lines=7..21;32..-1]
    # | +ifeval::["{foo}",  == "bar"]
    # | +include::{foo-path}bar.adoc[leveloffset=+1,,  lines=7..21;32..-1]
    # |  endif::[]

More details in the maillist post.

First PR here, I'll need someone to review please.

Thanks!

mquinson commented 3 years ago

Hello Danilo,

I did check your changes, and they look very good, many thanks! The only nitpicking remark could be that the the test could have been placed in another test. But I agree that what you needed to add was so small that it didn't really deserve a separate test.

Thanks for this contribution, and welcome onboard ;) Mt

dbaio commented 3 years ago

@mquinson thanks for the feedback and quick reviewing. Noted that for a future PR.