mquinson / po4a

Maintain the translations of your documentation with ease (PO for anything)
http://po4a.org/
GNU General Public License v2.0
121 stars 58 forks source link

markdown: support link reference #422

Closed gemmaro closed 1 year ago

gemmaro commented 1 year ago

This pull request marks link reference definitions in the markdown document as no-wrap, which avoids unintentional line breaks at the colon in the long link reference definition line.

Here are some limitations below, but I suspect it works in most cases:

mquinson commented 1 year ago

Hello @gemmaro, thanks for this PR. I see that it's marked as a draft, so I'll refrain from merging it, but it sounds pretty good to me. I'd love a little note in the NEWS file also, but I can do that myself afterward if you prefer.

What do you plan to do about it before unmarking it 'draft'?

Thanks again,

gemmaro commented 1 year ago

Hello! Thank you for your reply.

I marked it as a draft, since I wrote this late last night and was worried about doing something careless. I would like to try to make an addition to the NEWS file myself (and also install tidyall and see if it passes).

Best,

gemmaro commented 1 year ago

I updated regexp pattern, to accept indentation for example, according to the CommonMark specification. I also applied tidyall to format the code, and added about the change to the NEWS file.

mquinson commented 1 year ago

Merged, thanks.