Monk not getting martial arts added

[mr-ice]

https://www.dndbeyond.com/profile/Mr__Ice/characters/33247272 is a halfling monk with a spear. When initialized with yesterday's build the spear attacks don't look like they do in dndbeyond, the spear isn't getting the monk's martial arts applied (use Dex instead of Str).

[trey-kirk-sp]

Martial Arts will have to get the same treatment that Finesse got: There's no modifiers to read programmatically. We just have to look for it and apply the best ability choice when found

[mr-ice]

It is also not getting Martial Arts applied to Unarmed Strike. Fixes get thrown away on quick update.

[trey-kirk-sp]

Thinking through how this can be addressed after the last round of refactoring the token properties and RollExpressions. I see at least two approaches:

• DnDB builds matching attacks as weapon attacks with the weapon type set as Finesse. The existing token properties will naturally adapt the roll to apply the better if Strength and Dex, based on the current state of those two abilities. The con is that it's technically incorrect to label them as Finesse. But there's nothing that really cares about that right now.
• Or DnDB builds these attacks as Generic attacks with the Proficiency and Ability types added. The attack would still adapt to ability changes but wouldn't switch from Dex to Str in the event Dex drops too low.

I suppose there's a third solution which involves defining how a 3rd party Lib might introduce its own RE/Type prototypes. Stuff to think about...

[trey-kirk-sp]

Martial Arts is more than just acting like Finesse:

At 1st level, your practice of Martial Arts gives you mastery of Combat styles that use unarmed strikes and monk Weapons, which are shortswords and any simple Melee Weapons that don't have the Two-Handed or heavy property.

You gain the following benefits while you are unarmed or wielding only monk Weapons and you aren't wearing armor or wielding a Shield.

• You can use Dexterity instead of Strength for the Attack and Damage Rolls of your unarmed strikes and monk Weapons.

• You can roll a d4 in place of the normal damage of your Unarmed Strike or monk weapon.

That d4 increases as the Monk levels. So there's caveats to this feature that pretty much any Monk will already be satisfying (Wield only Monk Weapons, no armor/shield), but as always one must ask, "What Would Kayla Do?" She would build a Plate Mail wearing monk-tank duel-wielding a short sword and a halbred. And such a monstrosity does not get to apply Martial Arts to that short sword. So I think what we do is this:

• [ ] Write a class processor that updates the Basic Toon and applies class features for any class worth doing this do. So in this case, a Monk processor. Could also consider a Barbarian processor.
• [ ] For Martial Arts, the Monk processor would read the attacks and for each attack using a Monk weapon, create a second adorned with the best configuration for the Martial Arts version of the attack. Another example is the Barbarian could create "Raging" versions.
• [ ] At the end of the Basic Toon build process, apply an relevant class processors, applying only those for which the BasicToon has classes.
• [ ] Remove the extra feature detections we do when building attacks (ex. barbarian's extra crit dice). These would be features that are determined by name alone and not by any granted modifiers. Migrate these to the related class processor.

[havoclad]

Kayla says your concept is good, but she would prefer a dual classed Paladin/Monk to properly pull this off.