search

mr-karan / doggo

:dog: Command-line DNS Client for Humans. Written in Golang
https://doggo.mrkaran.dev/
GNU General Public License v3.0
2.83k stars 100 forks source link

Bug fix for correct https url parsing #135

Closed vksysd closed 2 months ago

vksysd commented 2 months ago

https://google.com is a valid url but doggo won't parse it to google.com before firing the DNS query. The URL needs to be parsed properly.

mr-karan commented 2 months ago

No it's not. DNS queries need a FQDN. That's different from a URL.

vksysd commented 2 months ago

Shouldn't we parse the user input before querying the DNS server?

On Wed, Jul 3, 2024 at 4:30 PM Karan Sharma @.***> wrote:

No it's not. DNS queries need a FQDN. That's different from a URL.

— Reply to this email directly, view it on GitHub https://github.com/mr-karan/doggo/issues/135#issuecomment-2205802042, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECV243UXFD53LS4O4CWQS3ZKPKV5AVCNFSM6AAAAABKJBHYX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVHAYDEMBUGI . You are receiving this because you authored the thread.Message ID: @.***>

--

Regards, Vikas Kumar Linkedin https://www.linkedin.com/in/vikascseiitb/

mr-karan commented 2 months ago

No. DNS clients are not supposed to do that, per RFC 1034