JK-PB2A16S20P Add temperature sensors 3 and 4

[tlamoureux24]

Is your feature request related to a problem? Please describe.

No

Describe the solution you'd like

Add battery temperature sensors number 3 and 4 in addition to numbers 1 and 2 and mosfet temperature.

Describe alternatives you've considered

No response

Additional context

No response

[KoljaWindeler]

Hey @mr-manuel, how motivating are command-tickets like that for you? Also: how much are people paying you for your work :) ?

I can take care of this though

[tlamoureux24]

Hey @mr-manuel, how motivating are command-tickets like that for you? Also: how much are people paying you for your work :) ?

I can take care of this though

hello, I don't know if this is ironic, humorous or something else ..... sorry I'm French and I use deepl ...... I posted this enhancement request with the proper form I think because I think it can improve the driver for everyone. If my request is badly formulated I apologize. Unless I'm mistaken, temperature values are used in some driver calculations, and what I've noticed on my battery, which is a 16-cell vertical pack, is that the batteries at the top are sometimes 2 to 3 degrees hotter than those at the bottom, so this can have some influence. Sorry for the inconvenience, my request can be closed.

[KoljaWindeler]

well maybe I should react a little easier, I'm maintaining some other projects and receive quite some "why is this not working, fix it!" messages .. and I guess I also speak for other open source contributor that we all do this work at our free time so a little "hey guys, thanks for the work, it would be awesome if you could add XYZ" would be nice ..

but anyway .. I already have temp3 and temp4 working and it is a good idea to add it .. will send out an update soon

[tlamoureux24]

You're right, I should have phrased it more politely and I apologize for that, and you're also right, opensource developers are often not thanked enough for their work. I don't know how to code, but I think I've contributed a little to my small level of knowledge by reporting bugs with all the information I can and testing everything I'm asked to. I've already had the opportunity to thank mr-manuel several times for his work and his time (please see https://github.com/mr-manuel/venus-os_dbus-serialbattery/issues/43 and https://github.com/mr-manuel/venus-os_dbus-serialbattery/issues/48 )

In any case, thank you for your time and your work on this and other projects. Have a nice day

[mr-manuel]

Hey @mr-manuel, how motivating are command-tickets like that for you?

Since I don't have the BMS, it's a bit hard to develop and test, but since it's a community project it relies on people like you.

Also: how much are people paying you for your work :) ?

In average I get about 40 € a month from donations, which would be 0,5 h of time of a programmer xD I spend easily over 60 hours a month between all support/bug/enhancement requests, tests and so on, for this project, so there is no relation between effort and revenue. People don't realize how much effort this is and want to have good support, if they donate once 5 €...

I was already thinking about implementing something like a bug bounty, where I set an amount for a feature and if enough donations are made for this feature, then it is developed. Until today, I found no transparent way to do this.

[KoljaWindeler]

should be working .. and

pull request submitted https://github.com/mr-manuel/venus-os_dbus-serialbattery/pull/53, please reopen if you have an issue Kolja

[tlamoureux24]

Thank you very much @KoljaWindeler and @mr-manuel for the work and the time paste on this enhancement.